RFR: 8283597: [REDO] Invalid generic signature for redefined classes

[Serguei Spitsyn]

On Mon, 28 Mar 2022 22:19:49 GMT, Alex Menkov <amenkov at openjdk.org> wrote:

> After pushing fix for JDK-8282241 (https://github.com/openjdk/jdk/pull/7676) random tests from serviceability/jvmti/RedefineClasses start to fail with
> java.lang.NoClassDefFoundError: jdk/test/lib/helpers/ClassFileInstaller$Manifest
> This is caused by JTReg classpath directories sharing between tests.
> 
> Research shown that the issue was caused by using
> run compile -g RedefineGenericSignatureTest.java
> in the test to include additional debug info.
> Actually "-g" it's not needed as the test only needs source file data and it's included by default.
> 
> The fix is the same as previous one, the only difference is in the test:
> - removed "run compile -g RedefineGenericSignatureTest.java" action;
> - removed "-g" option from InMemoryJavaCompiler.compile() call.
> 
> Tested with debug and release builds, 1500 runs without failures.
> 
> @coleenp , @sspitsyn : could you please re-review the fix

Looks good to me.
It is nice you've found the root cause of this regression!
Thanks,
Serguei

-------------

Marked as reviewed by sspitsyn (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/8007