RFR: 8283903: GetContainerCpuLoad does not return the correct result in share mode [v4]

Kevin Walls kevinw at openjdk.java.net
Wed Mar 30 12:22:45 UTC 2022


On Wed, 30 Mar 2022 11:02:18 GMT, xpbob <duke at openjdk.java.net> wrote:

>> ```        
>>                long hostTicks = getHostTotalCpuTicks0();
>>                 int totalCPUs = getHostOnlineCpuCount0();
>>                 int containerCPUs = getAvailableProcessors();
>>                 // scale the total host load to the actual container cpus
>>                 hostTicks = hostTicks * containerCPUs / totalCPUs;
>> 
>> hostTicks=175476155560000000
>> totalCPUs=96
>> containerCPUs=90
>> 
>> Calculate the overflow
>
> xpbob has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Change the expression

Marked as reviewed by kevinw (Committer).

OK thanks for the description update, and I think the updated code is better also.

I guess the app has not been running with the fix long enough to test it fully yet?  But if it's looking good so far and reporting good information, and any other tests are unaffected, then looks good.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8028


More information about the serviceability-dev mailing list