RFR: 8284161: Implementation of Virtual Threads (Preview) [v8]

[Leonid Mesnik]

On Fri, 29 Apr 2022 05:48:19 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:

>> Alan Bateman has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Refresh 7965cc6b168e567ac2596f2fbc3b00a7d99b7e1e
>
> test/hotspot/jtreg/serviceability/jvmti/events/Breakpoint/breakpoint01/libbreakpoint01.cpp line 66:
> 
>> 64:   for (i = 0; i < METH_NUM; i++)
>> 65:     bpEvents[i] = 0;
>> 66: }
> 
> Leonid, thank you for converting these tests from nsk.jvmti to provide test coverage for virtual threads!
> As I understand all new tests are C++ based.
> So, I'd suggest to always use C++ style of loops:
>   for (int i = 0; i < METH_NUM; i++)
> 
> This suggestion applies to all new tests in the serviceability/jvmti folder.
> One reason to keep old style would be to keep these tests comparable with the matching nsk.jvmti tests.
> However, I tried to compare and found out that the difference is already pretty big.
> You can consider this clean up after integration though.

fixed in all ported tests were applicable

-------------

PR: https://git.openjdk.java.net/jdk/pull/8166