RFR: 8283849: AsyncGetCallTrace may crash JVM on guarantee [v2]

Johannes Bechberger duke at openjdk.java.net
Thu May 5 12:13:19 UTC 2022


On Thu, 5 May 2022 11:59:16 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Jaroslav Bachorik has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Make sure the code blob result check is correct
>
> src/hotspot/share/runtime/thread.hpp line 647:
> 
>> 645: #endif // __APPLE__ && AARCH64
>> 646: 
>> 647:  // support ASGCT
> 
> Nit: the abbreviation for AsyncGetCallTrace is AGCT not ASGCT

I would like to disagree: The abbreviation "ASGCT" is used in multiple places in the JVM, especially in `forte.cpp` (where "AGCT" cannot be found).

-------------

PR: https://git.openjdk.java.net/jdk/pull/8549


More information about the serviceability-dev mailing list