RFR: 8283849: AsyncGetCallTrace may crash JVM on guarantee [v2]

Johannes Bechberger duke at openjdk.java.net
Thu May 5 13:26:16 UTC 2022


On Thu, 5 May 2022 12:55:31 GMT, Jaroslav Bachorik <jbachorik at openjdk.org> wrote:

>> Just to clarify - you mean finding a gap due to padding and putting the field there?
>> The rest of the fields are usually clustered around the supported functionality so before I insert this flag somewhere in the middle of unrelated fields I want to be sure this is what we want.
>
> I had tried identifying any gaps I might use but found none. Not saying they are none but it is rather difficult to spot anything with all the Thread related attributes spread across many lines, interspersed with the method declarations :(
> Any trick or tool I might use to find the right place for this attribute?

An option would be to place it after https://github.com/openjdk/jdk/blob/ce15582a7570b529a4c9b3d500f60fa0a2dc772d/src/hotspot/share/runtime/thread.hpp#L901 but it would make the code less coherent.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8549


More information about the serviceability-dev mailing list