RFR: 8283849: AsyncGetCallTrace may crash JVM on guarantee [v3]

David Holmes dholmes at openjdk.java.net
Fri May 6 01:21:48 UTC 2022


On Thu, 5 May 2022 12:40:02 GMT, Jaroslav Bachorik <jbachorik at openjdk.org> wrote:

>> src/hotspot/share/runtime/thread.hpp line 649:
>> 
>>> 647:  // support AGCT
>>> 648:  private:
>>> 649:   bool _in_agct;
>> 
>> This should actually be in JavaThread as AGCT only operates on JavaThreads.
>
> I will have to do check/cast in `CodeCache::find_blob()` as that may get called from any thread, not just Java threads.
> I would assume that having this flag defined at Thread level is a lesser of the evils - or am I wrong here?

We have been actively moving JavaThread fields out of Thread.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8549


More information about the serviceability-dev mailing list