RFR: 8286441: Remove mode parameter from jdk.internal.perf.Perf.attach() [v2]

[Ioi Lam]

On Tue, 10 May 2022 21:43:44 GMT, Claes Redestad <redestad at openjdk.org> wrote:

>> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   review comments
>
> src/hotspot/os/windows/perfMemory_windows.cpp line 1781:
> 
>> 1779: // address space.
>> 1780: //
>> 1781: void PerfMemory::attach(const char* user, int vmid,
> 
> One line?

Fixed

> src/hotspot/share/prims/perf.cpp line 84:
> 
>> 82: 
>> 83:   // attach to the PerfData memory region for the specified VM
>> 84:   PerfMemory::attach(user_utf, vmid,
> 
> One line?

Fixed

> src/hotspot/share/runtime/perfMemory.hpp line 146:
> 
>> 144:     // methods for attaching to and detaching from the PerfData
>> 145:     // memory segment of another JVM process on the same system.
>> 146:     static void attach(const char* user, int vmid,
> 
> One line?

Fixed

> src/jdk.jstatd/share/classes/sun/tools/jstatd/RemoteHostImpl.java line 74:
> 
>> 72:         Integer v = lvmid;
>> 73:         RemoteVm stub = null;
>> 74:         StringBuilder sb = new StringBuilder();
> 
> Suggestion:
> 
>         String vmidStr = "local://" + lvmid + "@localhost";

Fixed

-------------

PR: https://git.openjdk.java.net/jdk/pull/8622