RFR: 8283849: AsyncGetCallTrace may crash JVM on guarantee [v11]

Jaroslav Bachorik jbachorik at openjdk.java.net
Tue May 17 13:53:36 UTC 2022


On Tue, 17 May 2022 13:01:36 GMT, Johannes Bechberger <duke at openjdk.java.net> wrote:

>> Jaroslav Bachorik has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove ASGCTMark
>
> src/hotspot/share/prims/forte.cpp line 594:
> 
>> 592:   }
>> 593: 
>> 594:   // !important! make sure all return points will reset the IN_ASGCT flag to 'false'
> 
> Please change it to something like "// !important! make sure all to call set_in_asgct(false) before every return" as this is clearer in the context of the forte.cpp and omits mentioning the encapsulated state.

�� 
I have modified the comment wording

-------------

PR: https://git.openjdk.java.net/jdk/pull/8549


More information about the serviceability-dev mailing list