RFR: 8286490: JvmtiEventControllerPrivate::set_event_callbacks CLEARING_MASK computation is incorrect [v2]

Tue May 24 23:00:56 UTC 2022

On Tue, 24 May 2022 22:00:01 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> Serguei Spitsyn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   add extra test coverage for JVMTI extension events: VirtualThreadMount/VirtualThreadUnmount
>
> test/hotspot/jtreg/serviceability/jvmti/vthread/VThreadTest/libVThreadTest.cpp line 625:
> 
>> 623:   }
>> 624: 
>> 625:   err = jvmti->SetEventNotificationMode(JVMTI_ENABLE, JVMTI_EVENT_VIRTUAL_THREAD_END, NULL);
> 
> Why does the ordering matter for these 4 SetEventNotificationMode() calls?

You are right. This order does not matter.
What matters is the order of calls to SetExtensionEventCallback and SetEventCallbacks.
It is important to call SetExtensionEventCallback first in order to reproduce the issue.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8860