RFR: 8256072: Eliminate JVMTI tagmap rehashing [v3]

Kim Barrett kbarrett at openjdk.org
Thu Nov 3 03:44:47 UTC 2022


On Wed, 2 Nov 2022 22:23:57 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Use identity_hash for objects in the JVMTI TagMap table.  If the object has no hashcode, it's not in the table.
>> Tested with tier1-6.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove now-unused function that I missed.

Looks good.  Maybe just a little more deletion.

src/hotspot/share/gc/z/zHeap.inline.hpp line 48:

> 46: inline uint32_t ZHeap::hash_oop(uintptr_t addr) const {
> 47:   const uintptr_t offset = ZAddress::offset(addr);
> 48:   return ZHash::address_to_uint32(offset);

I think removal of the call to `ZHash::address_to_uint32` means this file no longer needs to include zHash.inline.hpp.

-------------

Marked as reviewed by kbarrett (Reviewer).

PR: https://git.openjdk.org/jdk/pull/10938


More information about the serviceability-dev mailing list