RFR: 8294241: Deprecate URL public constructors [v3]
Daniel Fuchs
dfuchs at openjdk.org
Thu Nov 3 11:20:08 UTC 2022
On Thu, 3 Nov 2022 07:42:44 GMT, ExE Boss <duke at openjdk.org> wrote:
>> Daniel Fuchs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
>>
>> - Integrated review feedback
>> - Merge branch 'master' into deprecate-url-ctor-8294241
>> - Updated after review comments. In particular var tmp => var => _unused - and avoid var in java.xml
>> - Merge branch 'master' into deprecate-url-ctor-8294241
>> - Fix whitespace issues
>> - 8294241
>
> src/java.base/share/classes/java/net/URL.java line 885:
>
>> 883: @SuppressWarnings("deprecation")
>> 884: var result = new URL("jrt", host, port, file, null);
>> 885: return result;
>
> Suggestion:
>
> return new URL("jrt", host, port, file, null);
Ah ! Good point thanks! I have accepted your suggestions.
-------------
PR: https://git.openjdk.org/jdk/pull/10874
More information about the serviceability-dev
mailing list