RFR: JDK-8295756 Improve NonLocalRegistry Manual Test Process [v3]

Bill Huang bhuang at openjdk.org
Sat Nov 5 00:04:40 UTC 2022


On Fri, 4 Nov 2022 15:17:43 GMT, Mahendra Chhipa <mchhipa at openjdk.org> wrote:

>> Bill Huang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Reverted exclusion of nonlocal registry tests.
>
> test/jdk/javax/management/remote/nonLocalAccess/NonLocalJMXRemoteTest.java line 222:
> 
>> 220:             System.out.printf("Found expected AccessException: %s%n%n", t);
>> 221:         } else {
>> 222:             throw new RuntimeException("AccessException did not occur when expected", ex);
> 
> private static void assertIsAccessException(Throwable ex) is define in all these three test classes, move this method in lib/jdk/test/lib

This method is test dependent that checks for specific keywords in the AccessException. It seems better remain inside the test classes.

-------------

PR: https://git.openjdk.org/jdk/pull/10825


More information about the serviceability-dev mailing list