RFR: 8295044: Implementation of Foreign Function and Memory API (Second Preview) [v2]

[Maurizio Cimadamore]

On Sat, 5 Nov 2022 18:02:33 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> Maurizio Cimadamore has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 17 additional commits since the last revision:
>> 
>>  - Merge branch 'master' into PR_20
>>  - Merge branch 'master' into PR_20
>>  - Merge pull request #14 from minborg/small-javadoc
>>    
>>    Update some javadocs
>>  - Update some javadocs
>>  - Revert some javadoc changes
>>  - Merge branch 'master' into PR_20
>>  - Fix benchmark and test failure
>>  - Merge pull request #13 from minborg/revert-factories
>>    
>>    Revert MemorySegment factories
>>  - Update javadocs after comments
>>  - Revert MemorySegment factories
>>  - ... and 7 more: https://git.openjdk.org/jdk/compare/d314527d...3d933028
>
> src/java.base/share/classes/jdk/internal/foreign/abi/BindingSpecializer.java line 477:
> 
>> 475:                 case UNBOX_ADDRESS -> emitUnboxAddress();
>> 476:                 case DUP -> emitDupBinding();
>> 477:                 case CAST -> emitCast((Binding.Cast) binding);
> 
> This contains the CAST binding, but not the accompanying VM changes from: https://github.com/openjdk/panama-foreign/pull/720 which removes the now dead code. Preferably both changes go together (and the code removal is pretty trivial, so I suggest including it here)

Why did the normalization test passed even w/o VM changes? Is that because the VM code changes are just removing what is now dead code, right?

-------------

PR: https://git.openjdk.org/jdk/pull/10872