RFR: JDK-8293450 Convert test/closed/sun/management/ shell tests to Java version
Bill Huang
bhuang at openjdk.org
Tue Nov 8 00:21:31 UTC 2022
On Mon, 7 Nov 2022 23:20:15 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:
>> There is no new changes in the open portion of JDK, but extracting common functionalities in bootstrap Utils to test/lib/Utils which can be used in the closed part.
>
> The refactoring looks pretty good.
> But I have a couple of questions.
> Q1: The method `grantAccess` is converted to the util method `grantFileAccess` and it does not look the same. Could you, please, explain what are the changes?
> Q2: I'm confused about conversion of the shell tests. Your fix does not convert any shell test. Also, I do not see any changes to the shell ile `test/jdk/sun/management/jmxremote/bootstrap/ReadWriteForbidsCreateTest.sh` listed in the enhancement. Can you explain, please?
Hi @sspitsyn, the methods `grantAccess` and `grantFileAccess` are almost identical except for the parameter `AccessControl access` being changed to a boolean which is used to indicate user access or full access. There is also a minor change in building a new ACL entry out of the original entry.
For your Q2 , it is in closed part of JDK. Please see the JBS ticket for the PR link.
-------------
PR: https://git.openjdk.org/jdk/pull/11029
More information about the serviceability-dev
mailing list