RFR: 8295303: cleanup debug agent's confusing use of EI_GC_FINISH [v2]

[Chris Plummer]

On Tue, 8 Nov 2022 01:16:06 GMT, Alex Menkov <amenkov at openjdk.org> wrote:

>> Chris Plummer has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fixed ei range check logic errors.
>
> src/jdk.jdwp.agent/share/native/libjdwp/eventHandler.c line 1512:
> 
>> 1510:      * so it cannot be setup using threadControl_setEventMode(). Use JVMTI API directly.
>> 1511:      */
>> 1512:     error = JVMTI_FUNC_PTR(gdata->jvmti,SetEventNotificationMode)
> 
> Please add space after the comma:
> error = JVMTI_FUNC_PTR(gdata->jvmti, SetEventNotificationMode)

Omitting the space is consistent with other uses of JVMTI_FUNC_PTR.

> src/jdk.jdwp.agent/share/native/libjdwp/util.c line 1983:
> 
>> 1981: {
>> 1982:     jdwpEvent event = 0;
>> 1983:     if (ei >= EI_min || ei >= EI_max) {
> 
> Should be "(ei >= EI_min && ei <= EI_max"

Fixed.

> src/jdk.jdwp.agent/share/native/libjdwp/util.c line 1996:
> 
>> 1994: {
>> 1995:     jvmtiEvent event = 0;
>> 1996:     if (ei >= EI_min || ei >= EI_max) {
> 
> Should be "(ei >= EI_min && ei <= EI_max"

Fixed.

-------------

PR: https://git.openjdk.org/jdk/pull/10887