RFR: 8295044: Implementation of Foreign Function and Memory API (Second Preview) [v11]

Jorn Vernee jvernee at openjdk.org
Tue Nov 8 18:18:08 UTC 2022


On Tue, 8 Nov 2022 18:14:21 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

>> This PR contains the API and implementation changes for JEP-434 [1]. A more detailed description of such changes, to avoid repetitions during the review process, is included as a separate comment.
>> 
>> [1] - https://openjdk.org/jeps/434
>
> Maurizio Cimadamore has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Address review comments
>  - More javadoc tweaks

Marked as reviewed by jvernee (Reviewer).

src/java.base/share/classes/java/lang/foreign/MemorySession.java line 67:

> 65:  * cannot be easily determined. As shown in the example above, a memory session that is managed implicitly cannot end
> 66:  * if a program references to one or more segments associated with that session. This means that memory segments associated
> 67:  * with implicitly managed can be safely {@linkplain #isAccessibleBy(Thread) accessed} from multiple threads.

Suggestion:

 * with implicitly managed sessions can be safely {@linkplain #isAccessibleBy(Thread) accessed} from multiple threads.

-------------

PR: https://git.openjdk.org/jdk/pull/10872


More information about the serviceability-dev mailing list