RFR: 8294881: test/hotspot/jtreg/vmTestbase/nsk/jdi/VirtualMachine/dispose/dispose003/TestDescription.java fails [v4]

Chris Plummer cjplummer at openjdk.org
Fri Nov 11 03:48:41 UTC 2022


On Thu, 10 Nov 2022 21:30:54 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

>> Change Thread.resume() to error reporting and add some time to complete thread.
>
> Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision:
> 
>   log message added.

Changes requested by cjplummer (Reviewer).

test/hotspot/jtreg/vmTestbase/nsk/jdi/VirtualMachine/dispose/dispose005a.java line 155:

> 153:                                  exitCode = FAILED;
> 154:                              } else {
> 155:                                  log1("checking on: test_tread.done");

tread -> thread

test/hotspot/jtreg/vmTestbase/nsk/jdi/VirtualMachine/dispose/dispose005a.java line 158:

> 156:                                  if (!test_thread.done) {
> 157:                                      pipe.println("alive");
> 158:                                      logErr("ERROR thread_thread.done is false after vm.dispose()");

thread_thread -> test_thread

test/hotspot/jtreg/vmTestbase/nsk/share/jdi/JDIUtils.java line 29:

> 27: 
> 28:     /*
> 29:      * Wait until thread which is supposed to complet become not alive.

How about:

"Wait until thread is no longer alive, but only wait for a short period of time since it shouldn't take long."

-------------

PR: https://git.openjdk.org/jdk/pull/10877


More information about the serviceability-dev mailing list