RFR: 8296796: Provide clean, platform-agnostic interface to C-heap trimming

David Holmes dholmes at openjdk.org
Mon Nov 14 01:39:31 UTC 2022


On Thu, 10 Nov 2022 13:23:34 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

> This is a breakout from [JDK-8293114](https://bugs.openjdk.org/browse/JDK-8293114), which is starved for reviews. So I attempt to break up that fix into smaller units which are hopefully easier to review separately.
> 
> We can trim the C-heap manually using jcmd since [JDK-8268893](https://bugs.openjdk.org/browse/JDK-8268893). This patch reshapes this code, cleaning it up in an OS-agnostic way. That will allow us to add implementions for other platforms (I have this on my list for AIX at least) and make review of 8293114 easier.

This looks good for doing what it says, but I have to wonder whether it is actually worthwhile doing this unless most OS/lib will support it? What will the implementation be in AIX?

Thanks

src/hotspot/share/utilities/globalDefinitions.hpp line 376:

> 374: 
> 375: #define PROPERFMT             SIZE_FORMAT "%s"
> 376: #define PROPERFMTARGS(S)      byte_size_in_proper_unit(S), proper_unit_for_byte_size(S)

style nit? lower-case 's'

-------------

PR: https://git.openjdk.org/jdk/pull/11089


More information about the serviceability-dev mailing list