RFR: 8296709: WARNING: JNI call made without checking exceptions [v3]

[Christoph Langer]

On Mon, 14 Nov 2022 11:07:52 GMT, Lutz Schmidt <lucy at openjdk.org> wrote:

> > Couldn't you simply add a second `doExec` statement in the existing test rather than copy the entire test file?
> 
> Actually, I first did it that way. And I did not like it. It's not just the doExec, you need to duplicate the checks as well. So far, it's just personal preference.
> 
> The test case with active jdwp agent produces two warnings, but I have a fix for only one of the warnings. @RealCLanger suggested to create a bug for the unresolved warning and problem-list the test case until the bug is fixed. If this is the way to go, I need a separate test file.

Hm, I also don't like the code duplication...

You could use 2 @run tags. Via the run tags you can create two runs of the test, one like the current "default" and antoher one passing the debugging agent option as additional parameter which you have to hand to the the java child process then, too. Generally you'd expect the same results, e.g. good return code, the hello world and no warnings.

With that approach you can then exclude the failing run via exclude list.

-------------

PR: https://git.openjdk.org/jdk/pull/11083