RFR: 8296089: Remove debug agent code for special handling of Thread.resume() [v3]

Chris Plummer cjplummer at openjdk.org
Mon Nov 14 18:42:26 UTC 2022


On Fri, 11 Nov 2022 07:01:19 GMT, Alan Bateman <alanb at openjdk.org> wrote:

> This is good cleanup, I had forgotten that the JDWP agent has code to defend against direct use of Thread.resume. The changes look good. Somewhat subjective, but I think I would have made the comment in commonSuspendByNode just say that the error is not possible and not refer to behavior that was possible in the past.

I'd like to keep the comment in place. We probably wouldn't have the sanity check without the old Thread.resume() code having existed at one point, so I think it is useful to the reader to know why it was placed there.

-------------

PR: https://git.openjdk.org/jdk/pull/10922


More information about the serviceability-dev mailing list