RFR: 8296786: Limit VM modes for com/sun/jdi/JdbLastErrorTest.java

Daniel D. Daugherty dcubed at openjdk.org
Mon Nov 14 22:52:04 UTC 2022


On Mon, 14 Nov 2022 13:19:38 GMT, Kevin Walls <kevinw at openjdk.org> wrote:

> This is a (trivial) change of the @requires statement in a test: 
> don't run in -Xcomp or -Xint modes, where the interaction of Windows' native GetLastError and Panama direct native access are known not to work well together.
> 
> Remove test/jdk/ProblemList-Xcomp.txt entry for this test.
> 
> Running jtreg directly (which would ignore problemlist) will now skip this test if e.g. those modes are given using -vmoption

It's a little odd that 8293829 was closed as "will not fix"
and this new bug is used to remove the entry for 8293829.
I can see the desire to make this change clean and clear
and not get tied up in the history and discussion of 8293829.

Thumbs up.

Also heads up that there is another fix coming for the same test:
[JDK-8296913](https://bugs.openjdk.org/browse/JDK-8296913) Correct enable preview idiom in JdbLastErrorTest.java

-------------

Marked as reviewed by dcubed (Reviewer).

PR: https://git.openjdk.org/jdk/pull/11136


More information about the serviceability-dev mailing list