RFR: 8295044: Implementation of Foreign Function and Memory API (Second Preview) [v22]

Maurizio Cimadamore mcimadamore at openjdk.org
Tue Nov 15 15:38:52 UTC 2022


On Tue, 15 Nov 2022 15:31:58 GMT, Per Minborg <pminborg at openjdk.org> wrote:

>> Maurizio Cimadamore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add `since` tag in Module/ModuleLayer preview methods
>
> src/java.base/share/classes/java/lang/foreign/MemorySegment.java line 163:
> 
>> 161:  * segment is derived from the address of the original segment, by adding an offset (expressed in bytes). The size of
>> 162:  * the sliced segment is either derived implicitly (by subtracting the specified offset from the size of the original segment),
>> 163:  * or provided explicitly. In other words, a sliced segment has <em>stricter</em> spatial bounds than those of the original segment:
> 
> Strictly, a sliced segment can have the *same* spatial bounds as the original segment.

True - but I think the current text is a good compromise e.g. it is narrative text. You can always dive into `MemorySegment::asSlice` and find out more.

-------------

PR: https://git.openjdk.org/jdk/pull/10872


More information about the serviceability-dev mailing list