RFR: 8296709: WARNING: JNI call made without checking exceptions [v6]
Christoph Langer
clanger at openjdk.org
Tue Nov 15 22:08:22 UTC 2022
On Tue, 15 Nov 2022 12:58:12 GMT, Lutz Schmidt <lucy at openjdk.org> wrote:
>> This small change fixes a warning that may pop up during runtime. May I please request reviews? Thank you!
>
> Lutz Schmidt has updated the pull request incrementally with one additional commit since the last revision:
>
> 8296709: use multiple test ids
I think we're getting there. A few further nits and now you also need to update the copyright year.
test/jdk/tools/launcher/TestXcheckJNIWarnings.java line 31:
> 29: * @test id=noagent
> 30: * @bug 8187442
> 31: * @summary Launching app with or without jdwp agent shouldn't produce any jni warnings.
You could keep the old text here.
test/jdk/tools/launcher/TestXcheckJNIWarnings.java line 34:
> 32: * @modules jdk.compiler
> 33: * jdk.zipfs
> 34: * @compile TestXcheckJNIWarnings.java
I think the @compile directive is not necessary
test/jdk/tools/launcher/TestXcheckJNIWarnings.java line 39:
> 37: * @test id=jdwp-agent
> 38: * @bug 8187442
> 39: * @summary Launching app with or without jdwp agent shouldn't produce any jni warnings.
Here the text should be: Launching app with jdwp agent shouldn't produce any jni warnings.
test/jdk/tools/launcher/TestXcheckJNIWarnings.java line 42:
> 40: * @modules jdk.compiler
> 41: * jdk.zipfs
> 42: * @compile TestXcheckJNIWarnings.java
@compile can be removed.
-------------
PR: https://git.openjdk.org/jdk/pull/11083
More information about the serviceability-dev
mailing list