RFR: 8296886: Fix various include sort order issues [v2]

Stefan Karlsson stefank at openjdk.org
Thu Nov 17 08:16:30 UTC 2022


On Mon, 14 Nov 2022 11:39:10 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> src/hotspot/os/windows/jvm_windows.cpp line 27:
>> 
>>> 25: #include "precompiled.hpp"
>>> 26: #include "include/jvm.h"
>>> 27: #include "os_windows.hpp"
>> 
>> os_windows should be at the end, included using `OS_HEADER("os")`.
>
> But should we be directly including os_windows.hpp, rather than including os.hpp?

Deferring those discussions to a potential separate RFE.

-------------

PR: https://git.openjdk.org/jdk/pull/11108


More information about the serviceability-dev mailing list