RFR: 8295424: adjust timeout for another JLI GetObjectSizeIntrinsicsTest.java subtest
Daniel D. Daugherty
dcubed at openjdk.org
Wed Nov 30 22:06:58 UTC 2022
On Wed, 23 Nov 2022 02:16:30 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> @jonathan-gibbons - Thanks for the review!
>>
>> I could not find an @requires incantation for saying do-not-use-slowdebug-bits
>> nor one for saying do-not-use-macosx-aarch64. I don't really do a lot with
>> @requires so I could be missing something.
>>
>>> it's too much like brushing the dirt under the carpet.
>>
>> Please see the parent bugs for [JDK-8297367](https://bugs.openjdk.org/browse/JDK-8297367)
>> and [JDK-8297369](https://bugs.openjdk.org/browse/JDK-8297369) and you'll
>> see that I have clearly documented the failures that I've been seeing. I do plan
>> to leave those bugs open, but I've gotten tired of accounting for those failures
>> in my weekly stress testing runs.
>
>> I could not find an @requires incantation for saying do-not-use-slowdebug-bits nor one for saying do-not-use-macosx-aarch64.
>
> Something like:
>
> `@requires vm.debug != slowdebug`
> `@requires !(os.arch == "aarch64" && os.family == "mac")`
@dholmes-ora:
> Something like:
>
> `@requires vm.debug != slowdebug` `@requires !(os.arch == "aarch64" && os.family == "mac")`
A change like this:
@@ -25,6 +25,7 @@
* @test
* @bug 8190312
* @summary test redirected URLs for -link
+ * @requires (vm.debug != slowdebug)
* @library /tools/lib ../../lib
* @modules jdk.compiler/com.sun.tools.javac.api
* jdk.compiler/com.sun.tools.javac.main
results in a complaint from jtreg like this:
test result: Error. Parse Exception: Syntax error in @requires expression: invalid name: slowdebug
`(vm.debug == true)`
`(vm.debug == false)`
both work as does just plain:
`vm.debug`
so `vm.debug` is a boolean and not a string.
-------------
PR: https://git.openjdk.org/jdk/pull/11278
More information about the serviceability-dev
mailing list