RFR: 8294308: Allow dynamically choosing the MEMFLAGS of a type without ResourceObj [v3]
Coleen Phillimore
coleenp at openjdk.org
Mon Oct 3 17:43:26 UTC 2022
On Thu, 29 Sep 2022 08:50:11 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:
>> src/hotspot/share/opto/compile.hpp line 1064:
>>
>>> 1062: delete _print_inlining_stream;
>>> 1063: };
>>> 1064:
>>
>> compile.cpp has print_inlining_stream_free() calls which will leak the stringStream now if called. I think this function needs to be removed and it should call the reset function to reinitialize the stream.
>> There should be compiler tests that will fail if print_inlining_stream_free() is called with a null _print_inlining_stream pointer (I think the delete should fail (?) with null)
>
> This is removed as part of https://github.com/openjdk/jdk/pull/10396 . The function used to be here but I merged with upstream when that went in. delete on null is OK, just like with free.
Ok, I see it removed now.
-------------
PR: https://git.openjdk.org/jdk/pull/10412
More information about the serviceability-dev
mailing list