RFR: 8288387: GetLocalXXX/SetLocalXXX spec should require suspending target thread [v2]
Serguei Spitsyn
sspitsyn at openjdk.org
Thu Oct 6 17:31:00 UTC 2022
> The spec of JVM TI GetLocalXXX/SetLocalXXX functions is updated to require the target thread to be suspended. If not suspended then the JVMTI_ERROR_THREAD_NOT_SUSPENDED error code is returned by the implementation.
>
> The CSR is: https://bugs.openjdk.org/browse/JDK-8294690
>
> A few tests are impacted by this fix:
>
> test/hotspot/jtreg/serviceability/jvmti/vthread/GetSetLocalTest
> test/hotspot/jtreg/serviceability/jvmti/vthread/VThreadTest
> test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/capability/CM01/cm01t011
>
>
> The following test has been removed as non-relevant any more:
> ` test/hotspot/jtreg/serviceability/jvmti/GetLocalVariable/GetLocalWithoutSuspendTest.java`
>
> New negative test has been added instead:
> ` test/hotspot/jtreg/serviceability/jvmti/GetLocalVariable/GetSetLocalUnsuspended.java`
>
> All JVM TI and JPDA tests were used locally for verification.
> They were also run in Loom repository with `JTREG_MAIN_WRAPPER=Virtual`.
>
> Mach5 test runs on all platforms are TBD.
Serguei Spitsyn has updated the pull request incrementally with one additional commit since the last revision:
addressed review comments about is_JavaThread_current and @enablePreview tag
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/10586/files
- new: https://git.openjdk.org/jdk/pull/10586/files/b2c341f1..5991659f
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=10586&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=10586&range=00-01
Stats: 16 lines in 2 files changed: 9 ins; 5 del; 2 mod
Patch: https://git.openjdk.org/jdk/pull/10586.diff
Fetch: git fetch https://git.openjdk.org/jdk pull/10586/head:pull/10586
PR: https://git.openjdk.org/jdk/pull/10586
More information about the serviceability-dev
mailing list