RFR: 8288387: GetLocalXXX/SetLocalXXX spec should require suspending target thread [v2]

[Serguei Spitsyn]

Hi Dmitry,

Do you have any plans to full review and approve this PR?
Thanks,
Serguei

From: hotspot-dev <hotspot-dev-retn at openjdk.org> on behalf of Dmitry Samersoff <dmitry.samersoff at bell-sw.com>
Date: Friday, October 7, 2022 at 1:34 AM
To: Serguei Spitsyn <sspitsyn at openjdk.org>, hotspot-dev at openjdk.org <hotspot-dev at openjdk.org>, serviceability-dev at openjdk.org <serviceability-dev at openjdk.org>
Subject: Re: RFR: 8288387: GetLocalXXX/SetLocalXXX spec should require suspending target thread [v2]
Hi Serguei,

Looks good for me. Thank you!

-Dmitry

On 06/10/2022 20:31, Serguei Spitsyn wrote:
> On Thu, 6 Oct 2022 07:16:44 GMT, Dmitry Samersoff <dsamersoff at openjdk.org> wrote:
>
>>> Serguei Spitsyn has updated the pull request incrementally with one additional commit since the last revision:
>>>
>>>    addressed review comments about is_JavaThread_current and @enablePreview tag
>>
>> src/hotspot/share/prims/jvmtiEnvBase.hpp line 180:
>>
>>> 178:     JavaThread* current = JavaThread::current();
>>> 179:     oop cur_obj = current->jvmti_vthread();
>>> 180:     bool is_current = jt == current && (cur_obj == NULL || cur_obj == thr_obj);
>>
>> It might be better to restructure this "if" and check for jt==current before we ask for cur_obj, or at least add brackets.
>
> Thank you for the comment.
> I've refactored it a little bit. Please, let me know if you agree with it.
>
> -------------
>
> PR: https://git.openjdk.org/jdk/pull/10586


--
Dmitry.Samersoff at bell-sw.com
Technical Professional at BellSoft
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/serviceability-dev/attachments/20221007/7014f4f2/attachment-0001.htm>