RFR: 8294689: The SA transported_core.html file needs quite a bit of work [v4]
Serguei Spitsyn
sspitsyn at openjdk.org
Mon Oct 10 20:22:17 UTC 2022
On Sat, 8 Oct 2022 15:35:24 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:
>> The main issues I set out to address are:
>>
>> - legacy Solaris references can be removed
>> - add help with dealing with Windows core files, most of important of which is use of PATH to find the dlls referenced by the core file.
>> - add help with dealing with macOS core files, most of important of which is using JAVA_HOME or DYLD_LIBRARY_PATH to find the dlls referenced by the core file.
>>
>> However, in the end it turned out to be a pretty substantial restructuring and rewrite.
>>
>> Here are links to the rendered old and new copies of the file:
>> [old file](https://htmlpreview.github.io/?https://github.com/openjdk/jdk/blob/master/src/jdk.hotspot.agent/doc/transported_core.html)
>> [new file rev1](https://htmlpreview.github.io/?https://github.com/openjdk/jdk/blob/6778a202a855a534754c4b47a6cd99cb912869d3/src/jdk.hotspot.agent/doc/transported_core.html)
>> [new file rev2](https://htmlpreview.github.io/?https://github.com/openjdk/jdk/blob/7448593f0a9142e5d99844f349b4d54819735540/src/jdk.hotspot.agent/doc/transported_core.html)
>> [new file rev3](https://htmlpreview.github.io/?https://github.com/openjdk/jdk/blob/ce5c808ca5af4e551bf78d593d865a1f228ad950/src/jdk.hotspot.agent/doc/transported_core.html)
>> [new file rev4](https://htmlpreview.github.io/?https://github.com/openjdk/jdk/blob/3b16e560499eb526d283a9c16531cc1c3f63394e/src/jdk.hotspot.agent/doc/transported_core.html)
>
> Chris Plummer has updated the pull request incrementally with one additional commit since the last revision:
>
> some minor edits
src/jdk.hotspot.agent/doc/transported_core.html line 37:
> 35:
> 36: <p>
> 37: On most platforms, core dumps do not contain text (code) pages.
Nit: an extra space in "On most".
src/jdk.hotspot.agent/doc/transported_core.html line 50:
> 48: </p>
> 49:
> 50: <h3>Using transported core dumps on Linux</h3>
Nit: an extra space after "Using".
-------------
PR: https://git.openjdk.org/jdk/pull/10518
More information about the serviceability-dev
mailing list