RFR: 8276687: Remove support for JDK 1.4.1 PerfData shared memory files
Ioi Lam
iklam at openjdk.org
Thu Oct 13 19:44:38 UTC 2022
On Thu, 13 Oct 2022 10:49:09 GMT, Kevin Walls <kevinw at openjdk.org> wrote:
> Maybe the 3 classes in src/jdk.internal.jvmstat/share/classes/sun/jvmstat/perfdata/monitor/v1_0/ are redundant...? We parse a version number in AbstractPerfDataBuffer.createPerfDataBuffer() and create e.g. sun.jvmstat.perfdata.monitor.v2_0.PerfDataBuffer I don't have evidence of exactly where version 2 starts (I know it was in jdk5, but maybe it was 1.4.2), so I'm not saying the removal should be done now. Anyway, looks good.
I have filed https://bugs.openjdk.org/browse/JDK-8295253 to remove the "kludge" code for supporting 1.4.1 in the monitor/v1_0/ code. Because of this kludge code, I suspect that v1_0 actually supports versions other than 1.4.1, so I am hesitant of removing the entire v1_0 directory. More investigation is needed.
-------------
PR: https://git.openjdk.org/jdk/pull/10687
More information about the serviceability-dev
mailing list