RFR: 8276687: Remove support for JDK 1.4.1 PerfData shared memory files [v2]

[Ioi Lam]

On Thu, 13 Oct 2022 09:56:42 GMT, Kevin Walls <kevinw at openjdk.org> wrote:

>> src/jdk.internal.jvmstat/share/classes/sun/jvmstat/perfdata/monitor/protocol/local/PerfDataFile.java line 94:
>> 
>>> 92:         } catch (NumberFormatException e) { }
>>> 93: 
>>> 94:         throw new IllegalArgumentException("file name does not match pattern");
>> 
>> Pre-existing but it would be nice if this actually reported the file and the pattern.
>
> Maybe "cannot convert 'filename' to VM id".  (Or to pid.)  We just parse it as an Integer now, so showing the problem filename would be nice.  (Not sure if we would get this far trying a 1.4.1 attach, but if we did, it would help diagnose that.)

David and Kevin, thanks for the suggestions. I've update the error message. Does it look OK now?

-------------

PR: https://git.openjdk.org/jdk/pull/10687