RFR: 8291555: Replace stack-locking with fast-locking [v3]

Roman Kennke rkennke at openjdk.org
Fri Oct 14 15:42:01 UTC 2022


On Fri, 14 Oct 2022 14:53:57 GMT, Fei Yang <fyang at openjdk.org> wrote:

> > > > > > > Here is the basic support for RISC-V: https://cr.openjdk.java.net/~shade/8291555/riscv-patch-1.patch
> > > > > > > -- I adapted this from AArch64 changes, and tested it very lightly. @RealFYang, can I leave the testing and follow up fixes to you?
> > > > > > 
> > > > > > 
> > > > > > @shipilev : Sure, I am happy to to that! Thanks for porting this to RISC-V :-)
> > > > > 
> > > > > 
> > > > > @shipilev : After applying this on today's jdk master, linux-riscv64 fastdebug fail to build on HiFive Unmatched. I see JVM crash happens during the build process. I suppose you carried out the test with some release build, right?
> > > > 
> > > > 
> > > > Have you applied the whole PR? Or only the patch that @shipilev provided. Because only the patch without the rest of the PR is bound to fail.
> > > 
> > > 
> > > Yes, the whole PR: https://patch-diff.githubusercontent.com/raw/openjdk/jdk/pull/10590.diff
> > 
> > 
> > The PR reports a merge conflict in risc-v code, when applied vs latest tip. Have you resolved that? GHA (which includes risc-v) is happy, otherwise.
> 
> @rkennke : I did see some "Hunk succeeded" messages for the risc-v part when applying the change with: $ patch -p1 < ~/10590.diff But I didn't check whether that will cause a problem here.

If you take the latest code from this PR, it would already have the patch applied. No need to patch it again.

-------------

PR: https://git.openjdk.org/jdk/pull/10590


More information about the serviceability-dev mailing list