Integrated: 8288387: GetLocalXXX/SetLocalXXX spec should require suspending target thread

Serguei Spitsyn sspitsyn at openjdk.org
Mon Oct 17 23:39:15 UTC 2022


On Wed, 5 Oct 2022 22:49:20 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:

> The spec of JVM TI GetLocalXXX/SetLocalXXX functions is updated to require the target thread to be suspended. If not suspended then the JVMTI_ERROR_THREAD_NOT_SUSPENDED error code is returned by the implementation.
> 
> The CSR is: https://bugs.openjdk.org/browse/JDK-8294690
> 
> A few tests are impacted by this fix:
> 
>  test/hotspot/jtreg/serviceability/jvmti/vthread/GetSetLocalTest
>  test/hotspot/jtreg/serviceability/jvmti/vthread/VThreadTest
>  test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/capability/CM01/cm01t011
> 
> 
> The following test has been removed as non-relevant any more:
> `  test/hotspot/jtreg/serviceability/jvmti/GetLocalVariable/GetLocalWithoutSuspendTest.java`
>   
> New negative test has been added instead:
> `  test/hotspot/jtreg/serviceability/jvmti/GetLocalVariable/GetSetLocalUnsuspended.java`
> 
> All JVM TI and JPDA tests were used locally for verification.
> They were also run in Loom repository with `JTREG_MAIN_WRAPPER=Virtual`. 
> 
> Mach5 test runs on all platforms are TBD.

This pull request has now been integrated.

Changeset: 21a825e0
Author:    Serguei Spitsyn <sspitsyn at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/21a825e059170e3a069b9f0982737c5839e6dae2
Stats:     1202 lines in 12 files changed: 457 ins; 694 del; 51 mod

8288387: GetLocalXXX/SetLocalXXX spec should require suspending target thread

Reviewed-by: lmesnik, dsamersoff

-------------

PR: https://git.openjdk.org/jdk/pull/10586


More information about the serviceability-dev mailing list