RFR: 8295427: popframe004: report more details on error

Serguei Spitsyn sspitsyn at openjdk.org
Tue Oct 18 00:10:21 UTC 2022


On Mon, 17 Oct 2022 19:22:26 GMT, Alex Menkov <amenkov at openjdk.org> wrote:

> Failures of the test are usually caused by unexpected frame in the stack.
> Also the failures are intermittent, so it makes sense to report more details on error to simplify analysis.
> The fix adds stack trace printing if the test fails

test/hotspot/jtreg/vmTestbase/nsk/jvmti/PopFrame/popframe004/popframe004.cpp line 88:

> 86: }
> 87: 
> 88: static void printStackTrace(jvmtiEnv *jvmti, jthread thread) {

We normally use C naming convention for function names.
The exception is JVMTI event call backs.
I wonder if we already have some library functions for nsk tests.
For serviceability/jvmti tests we already have this:
`  test/lib/jdk/test/lib/jvmti/jvmti_common.h`
We may want something similar for nsk/jvmti tests.
It'd make sense to check with Leonid on what approach to take.

-------------

PR: https://git.openjdk.org/jdk/pull/10733


More information about the serviceability-dev mailing list