RFR: 8295427: popframe004: report more details on error [v2]

[Serguei Spitsyn]

On Wed, 19 Oct 2022 20:02:55 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> Alex Menkov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   merged serviceability/jvmti and nsk/share/jvmti shared code
>
> test/hotspot/jtreg/vmTestbase/nsk/share/jni/jni_tools.h line 136:
> 
>> 134:  * Declared and defined in jvmti_common.h
>> 135:  */
>> 136: //char *jlong_to_string(jlong value, char *string);
> 
> It seems odd to have jlong_to_string and julong_to_string implemented in different places. Maybe more cleanup is needed here.

I'd suggest to move julong_to_string to the same place where the jlong_to_string is placed and remove all these with the comments from jni_tools.
I agree, we may need to file a separate bug for global cleanup which should get rid of JVMTITools.*.

-------------

PR: https://git.openjdk.org/jdk/pull/10733