RFR: 8295697: Resolve conflicts between serviceability/jvmti and nsk/jvmti shared code [v3]

Chris Plummer cjplummer at openjdk.org
Thu Oct 20 01:20:49 UTC 2022


On Thu, 20 Oct 2022 00:18:10 GMT, Alex Menkov <amenkov at openjdk.org> wrote:

>> The fix resolved conflicts between jvmti test shared code: test/lib/jdk/test/lib/jvmti/jvmti_common.h and test/hotspot/jtreg/vmTestbase/nsk/share/jvmti/* to allot NSK tests to use jvmti_common.h
>> 
>> testing: test native libraries are built before any test execution, so run build job should be enough, but for safety I also run test/hotspot/jtreg/vmTestbase/nsk/jvmti and test/hotspot/jtreg/serviceability/jvmti
>
> Alex Menkov has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Moved julong_to_string to jvmti_common.h
>  - reverted changes in popframe004.cpp

Looks good!

-------------

Marked as reviewed by cjplummer (Reviewer).

PR: https://git.openjdk.org/jdk/pull/10733


More information about the serviceability-dev mailing list