RFR: 8295729: Add jcheck whitespace checking for properties files [v2]
Andy Goryachev
angorya at openjdk.org
Mon Oct 24 19:22:38 UTC 2022
On Fri, 21 Oct 2022 08:17:46 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:
>> Properties files is essentially source code. It should have the same whitespace checks as all other source code, so we don't get spurious trailing whitespace changes.
>>
>> With the new Skara jcheck, it is possible to increase the coverage of the whitespace checks (in the old mercurial version, this was more or less impossible).
>>
>> The only manual change is to `.jcheck/conf`. All other changes were made by running `find . -type f -iname "*.properties" | xargs gsed -i -e 's/[ \t]*$//'`.
>
> Magnus Ihse Bursie has updated the pull request incrementally with two additional commits since the last revision:
>
> - Remove check for .properties from jcheck
> - Restore trailing whitespace for property values
368 files to review! I wish we had separate PRs for fixing properties and checking for trailing whitespace. i 'd expect it will take some time to review localization, unless we just keep them as is.
-------------
PR: https://git.openjdk.org/jdk/pull/10792
More information about the serviceability-dev
mailing list