RFR: 8295816: jdwp jck tests failing with "FATAL ERROR in native method: JDWP SetTag, jvmtiError=JVMTI_ERROR_WRONG_PHASE(112)"

[Chris Plummer]

On Mon, 24 Oct 2022 21:09:05 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:

> I hope it solves the problem observed with the JCK tests.
> In fact, we sometimes keep forgetting to run JCK tests. 👍

Yes, but it's also turning up with some JDI tests. I did a lot of testing, and have done a bunch since for other changes I'm working on, and this never turned up. I did get it to turn up once yesterday after doing about 100 jck runs. However, it seems to be turning up a lot more than that in our CI runs. I'm not sure why.

> src/jdk.jdwp.agent/share/native/libjdwp/classTrack.c line 103:
> 
>> 101:     }
>> 102: 
>> 103:     if (gdata->assertOn) {
> 
> Just a question.
> Why the check for non-NULL gdata was removed?
> Is it because gdate is always non-NULL?

It's created during the OnLoad and never freed, so it can never be null once this callback is setup.

-------------

PR: https://git.openjdk.org/jdk/pull/10831