RFR: 8295810: cleanup debug agent removeThread() api

Chris Plummer cjplummer at openjdk.org
Mon Oct 24 23:07:41 UTC 2022


On Mon, 24 Oct 2022 22:56:08 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:

>> src/jdk.jdwp.agent/share/native/libjdwp/threadControl.c line 322:
>> 
>>> 320:     ThreadNode *next;
>>> 321: 
>>> 322:     JDI_ASSERT(list == node->list);
>> 
>> "list" argument is redundant
>> I suggest to drop it and replace this assert with
>> `ThreadList *list == node->list;`
>
> I was almost to suggest the same.

Yes. I did the assert to first convince myself that this would always be the case. I was thinking it would be good to leave as-is until we get a full round of testing first. Are you ok if I file an RFE instead?

-------------

PR: https://git.openjdk.org/jdk/pull/10828


More information about the serviceability-dev mailing list