RFR: 8294881: test/hotspot/jtreg/vmTestbase/nsk/jdi/VirtualMachine/dispose/dispose003/TestDescription.java fails [v2]

Thu Oct 27 03:41:34 UTC 2022

On Thu, 27 Oct 2022 01:54:00 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

>> Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   All dispose tests fixed.
>
> test/hotspot/jtreg/vmTestbase/nsk/jdi/VirtualMachine/dispose/dispose003a.java line 139:
> 
>> 137:                                  log1("checking on: thread2.isAlive");
>> 138:                                  // There is no sync between vm.dispose() and test_thread
>> 139:                                  // let give thread some time to complete
> 
> nit typo: s/let give/let us give/
> Also period at the end of the sentence.

comments removed, code moved to util class

-------------

PR: https://git.openjdk.org/jdk/pull/10877