RFR: 8295964: Move InstanceKlass::_misc_flags

Coleen Phillimore coleenp at openjdk.org
Mon Oct 31 12:55:36 UTC 2022


On Fri, 28 Oct 2022 03:59:45 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> src/hotspot/share/prims/jvmtiRedefineClasses.cpp line 4408:
>> 
>>> 4406:   if (!the_class->has_been_redefined()) {
>>> 4407:     the_class->set_has_been_redefined();
>>> 4408:   }
>> 
>> Nit: Is this change really needed?
>
> Seems unrelated to this refactoring. If really a bug it should be fixed separately.

This is needed by this change.  The has_been_redefined flag can be set at runtime and with these flags, there's an assert for all that they're only set once.  This one didn't have the assert but it can only be set in a safepoint, so I have this code to make it an exception. For now.  The plan is to make the _flags set once, and the _status field (to be added) set at runtime, and this can be moved to that.

-------------

PR: https://git.openjdk.org/jdk/pull/10249


More information about the serviceability-dev mailing list