RFR: 8293006: sun/tools/jhsdb/JStackStressTest.java fails with "UnalignedAddressException: 8baadbabe" [v2]

[Chris Plummer]

On Thu, 1 Sep 2022 17:21:55 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:

>> Chris Plummer has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Minor indent, spelling, and formatting fixes
>
> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/JavaThread.java line 357:
> 
>> 355:       obj = vmOopHandle.resolve();
>> 356:     } catch (Exception e) {
>> 357:         System.out.println("WARNING: could not get Thread object: " + e);
> 
> nit: This code seems to use an indent of 2 spaces.

fixed

> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/JavaThread.java line 516:
> 
>> 514:       Oop threadOop = this.getThreadObj();
>> 515:       if (threadOop == null) {
>> 516:           System.out.println("Could not get the java Thread object. Thread info will be limitted.");
> 
> typo: s/limitted/limited/

fixed

> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/JavaThread.java line 546:
> 
>> 544:       out.print(this.getAddress());
>> 545:       out.print(" nid=");
>> 546:       out.print(String.format("%d ",this.getOSThread().threadId()));
> 
> nit space after ','

fixed

> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/JavaThread.java line 550:
> 
>> 548:       out.print(" [");
>> 549:       if (this.getLastJavaSP() == null) {
>> 550:           out.print(String.format(ADDRESS_FORMAT,0L));
> 
> nit: space after ','

fixed

> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/JavaVFrame.java line 69:
> 
>> 67:       } else {
>> 68:           klassName = "<unknown class>";
>> 69:       }
> 
> nit: existing code uses 2 spaces, but your addition uses 4.

fixed

-------------

PR: https://git.openjdk.org/jdk/pull/10088