RFR: 8291586: Broken links in JVMTI specification
Serguei Spitsyn
sspitsyn at openjdk.org
Sat Sep 3 01:01:11 UTC 2022
The Loom related spec of the extension VirtualThreadMount and VirtualThreadUnmount events in the jvmti.xml is surrounded by the elements `<elide> ... </elide>`, so these specs have to be ignored when the `jvmti.html `is generated. However the `jvmti.xsl` which does the XSL transformation misses to do that when the description of the JVM TI capabilities is collected.
The fix is a one-liner:
diff --git a/src/hotspot/share/prims/jvmti.xsl b/src/hotspot/share/prims/jvmti.xsl
index 5ef89f91daf..d54d2a371e6 100644
--- a/src/hotspot/share/prims/jvmti.xsl
+++ b/src/hotspot/share/prims/jvmti.xsl
@@ -1172,7 +1172,7 @@ typedef struct {
</tr>
<xsl:for-each select="//capabilityfield">
<xsl:variable name="capa" select="@id"/>
- <xsl:variable name="events" select="//event[capabilities/required/@id=$capa]"/>
+ <xsl:variable name="events" select="//event[capabilities/required/@id=$capa and not(ancestor::elide)]"/>
<xsl:if test="count($events)">
<tr>
<th scope="row">
The correctness verification both the generated `jvmti.html` and `jvmti.h` was checked.
TBD: mach5 sanity builds and `nsk.jvmti` tests runs.
-------------
Commit messages:
- 8291586: Broken links in JVMTI specification
Changes: https://git.openjdk.org/jdk/pull/10153/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=10153&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8291586
Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
Patch: https://git.openjdk.org/jdk/pull/10153.diff
Fetch: git fetch https://git.openjdk.org/jdk pull/10153/head:pull/10153
PR: https://git.openjdk.org/jdk/pull/10153
More information about the serviceability-dev
mailing list