RFR: 8293432: Use diamond operator in java.management
Andrey Turbanov
aturbanov at openjdk.org
Tue Sep 6 13:28:26 UTC 2022
On Mon, 5 Sep 2022 19:56:44 GMT, Andrey Turbanov <aturbanov at openjdk.org> wrote:
> The diamond operator was introduced in Java 7. We can take advantage of this language feature to make code easier to read.
> Tested on Linux release x64. `make test TEST="jdk/java/lang/management jdk/javax/management jdk/com/sun/jmx jdk/sun/management"`
>
> Test summary
> ==============================
> TEST TOTAL PASS FAIL ERROR
> jtreg:test/jdk/java/lang/management 69 69 0 0
> jtreg:test/jdk/javax/management 246 246 0 0
> jtreg:test/jdk/com/sun/jmx 3 3 0 0
>>> jtreg:test/jdk/sun/management 33 32 0 1 <<
>
> Single failure - is a test `RmiBootstrapTest.java#id1`. It's known issue - [JDK-8293335](https://bugs.openjdk.org/browse/JDK-8293335).
src/java.management/share/classes/com/sun/jmx/mbeanserver/ClassLoaderRepositorySupport.java line 89:
> 87: **/
> 88: private synchronized boolean add(ObjectName name, ClassLoader cl) {
> 89: List<LoaderEntry> l = new ArrayList<>(Arrays.asList(loaders));
I found it strange that ArrayList is used to just append one element to array. I think it's better to just use Arrays.copyOf with length+1.
-------------
PR: https://git.openjdk.org/jdk/pull/10173
More information about the serviceability-dev
mailing list