RFR: 8293218: serviceability/tmtools/jstat/GcNewTest.java fails with "Error in the percent calculation" [v2]
Serguei Spitsyn
sspitsyn at openjdk.org
Fri Sep 9 09:16:52 UTC 2022
On Fri, 9 Sep 2022 08:26:47 GMT, Kevin Walls <kevinw at openjdk.org> wrote:
>> Test update to cope with heap size changing (shrinking) in the early life of the test app.
>>
>> A change in GC timing affects this test which reads eden size and heap size. Both eden and heap are likely to shrink initially for this test. Failures were that heap size shrank after reading eden size, such that eden appeared to be >100% of heap.
>> Recognising a shrinking heap and retrying resolves this.
>>
>> (Re-ordering to read heap size then eden would be enough to make the check in provokeGc work. But it would allocate sometimes a very small fraction of the heap, which is not the intent.)
>
> Kevin Walls has updated the pull request incrementally with one additional commit since the last revision:
>
> Remove outer loop
Looks good.
Thanks,
Serguei
-------------
Marked as reviewed by sspitsyn (Reviewer).
PR: https://git.openjdk.org/jdk/pull/10218
More information about the serviceability-dev
mailing list