RFR: 8293218: serviceability/tmtools/jstat/GcNewTest.java fails with "Error in the percent calculation" [v3]

Kevin Walls kevinw at openjdk.org
Fri Sep 16 16:59:11 UTC 2022


On Wed, 14 Sep 2022 05:50:32 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:

>> Kevin Walls has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Clarify that loop is for checking heap not changing.  Exception if continually changing.
>
> test/hotspot/jtreg/serviceability/tmtools/jstat/utils/GcProvoker.java line 76:
> 
>> 74:                 System.gc();
>> 75:                 continue;
>> 76:             } else {
> 
> In fact, the `else-statement` is not needed here because the `if-statement` is ended with `continue`.
> At least, this looks confusing to me.

OK sure, just updated to remove else, and add a comment which may help.

-------------

PR: https://git.openjdk.org/jdk/pull/10218


More information about the serviceability-dev mailing list