RFR: 8293218: serviceability/tmtools/jstat/GcNewTest.java fails with "Error in the percent calculation" [v4]

Kevin Walls kevinw at openjdk.org
Sat Sep 17 09:59:06 UTC 2022


On Fri, 16 Sep 2022 16:59:10 GMT, Kevin Walls <kevinw at openjdk.org> wrote:

>> Test update to cope with heap size changing (shrinking) in the early life of the test app.
>> 
>> A change in GC timing affects this test which reads eden size and heap size.  Both eden and heap are likely to shrink initially for this test.  Failures were that heap size shrank after reading eden size, such that eden appeared to be >100% of heap.
>> Recognising a shrinking heap and retrying resolves this.  
>> 
>> (Re-ordering to read heap size then eden would be enough to make the check in provokeGc work.  But it would allocate sometimes a very small fraction of the heap, which is not the intent.)
>
> Kevin Walls has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove else. Add comment.

OK thanks for all the comments, this is looking like a reasonable robustness improvement, and I can't trigger a failure.  Will integrate.

-------------

PR: https://git.openjdk.org/jdk/pull/10218


More information about the serviceability-dev mailing list