RFR: 8289607: Change com/sun/jdi tests to not use Thread.suspend/resume [v2]

Chris Plummer cjplummer at openjdk.org
Tue Sep 20 22:05:50 UTC 2022


On Tue, 20 Sep 2022 21:11:30 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:

>> Leonid Mesnik has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   revert changes
>
> test/hotspot/jtreg/testlibrary/jvmti/libJvmtiUtils.cpp line 84:
> 
>> 82:   }
>> 83:   check_jvmti_status(jni, err, "Error during ResumeThread");
>> 84: }
> 
> Would it better to return the jvmtiError status as an int, so it can be checked at the java level?
> In fact, it is not good that the `JVMTI_ERROR_THREAD_NOT_ALIVE`, `JVMTI_ERROR_THREAD_SUSPENDED` and `JVMTI_ERROR_THREAD_NOT_SUSPENDED` are always ignored.

I was going to ask something similar. Should the tests ever see these errors? If not, probably an exception should be thrown here. If they are ok in some situations, then the tests should be checking for them.

-------------

PR: https://git.openjdk.org/jdk/pull/10351


More information about the serviceability-dev mailing list