RFR: 8294411: SA should provide more useful info when it fails to start up due to "failed to workaround classshareing"

[Chris Plummer]

Sometimes SA fails to startup with the following error message:

ERROR: failed to workaround classshareing
Unable to open core file

The code in question is init_classsharing_workaround() in ps_core_common.c. There a number of reasons why the class sharing work around can fail, and the reason is usually pretty well described with a print_debug() statement. However, since this is an error, these should really just be print_error() statements so the user doesn't need to figure out how to get more info by setting LIBSAPROC_DEBUG (which may also produce a ton of output unrelated to the error).

-------------

Commit messages:
 - Fix indentation.
 - Changed many cases of debug output to error output.

Changes: https://git.openjdk.org/jdk/pull/10438/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=10438&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8294411
  Stats: 15 lines in 1 file changed: 2 ins; 0 del; 13 mod
  Patch: https://git.openjdk.org/jdk/pull/10438.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/10438/head:pull/10438

PR: https://git.openjdk.org/jdk/pull/10438