RFR: 8294411: SA should provide more useful info when it fails to start up due to "failed to workaround classshareing"

[Serguei Spitsyn]

On Tue, 27 Sep 2022 05:16:35 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

> Sometimes SA fails to startup with the following error message:
> 
> ERROR: failed to workaround classshareing
> Unable to open core file
> 
> The code in question is init_classsharing_workaround() in ps_core_common.c. There a number of reasons why the class sharing work around can fail, and the reason is usually pretty well described with a print_debug() statement. However, since this is an error, these should really just be print_error() statements so the user doesn't need to figure out how to get more info by setting LIBSAPROC_DEBUG (which may also produce a ton of output unrelated to the error).

Looks good.
Thanks,
Serguei

-------------

Marked as reviewed by sspitsyn (Reviewer).

PR: https://git.openjdk.org/jdk/pull/10438